Fix custom resources often missing from Quick Load dialog #93909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Jul 4, 2024
akien-mga
force-pushed
the
missing-custom-resources
branch
from
98a7cef
to
3afc777
Compare
|
Rebased to edit the commit message. Please make sure to use a meaningful commit message for future PRs, see https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind |
akien-mga
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Seems to fix the bug from a quick test, though the bug's apparent randomness is hard to correlate with how it's being fixed.
The code could maybe be made slightly cleaner but the only ideas I have may actually be more confusing that the current one, e.g.:
FileCache fc;
fc.type = split[1].get_slice("/", 0);
fc.resource_script_class = split[1].get_slice("/", 1); // Empty string if there's no separator.I think I prefer the has check which makes it clear it's not always present.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93813
Fixed the assignment to
fc.resource_script_classandfc.type